Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable29] fix(LinkBubble): Fix logic to detect transactions without history #5955

Merged
merged 1 commit into from
Jun 26, 2024
Merged

[stable29] fix(LinkBubble): Fix logic to detect transactions without history #5955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/components/Link/LinkBubbleView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export default {

removeLink() {
this.editor.chain()
// Explicitly hide bubble to prevent flickering before it's removed
.hideLinkBubble()
.unsetLink()
.focus()
Expand Down
2 changes: 1 addition & 1 deletion src/plugins/links.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export function linkBubble(options) {
const sameSelection = oldState?.selection.eq(state.selection)
const sameDoc = oldState?.doc.eq(state.doc)
// Don't open bubble on changes by other session members
const noHistory = !transactions.some(tr => tr.meta.addToHistory)
const noHistory = transactions.every(tr => tr.meta.addToHistory === false)
if (sameSelection && (noHistory || sameDoc)) {
return
}
Expand Down
Loading