fix(vite): dedupe vue to only use one version of it #6024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building locally against linked nextcloud-vue, custom reference widgets didn't load since we migrated to vite as builder and module bundler. Apparently this was because webpack before didn't use modules but vite now does. So apparently the two vue dependencies from nextcloud-vue and text are suddenly treated as separate modules and have separate states. Adding `vue` to `resolve.dedupe` in the vite config solves, as it forces vite to only use vue from the root project (text). Fixes: #5958 Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building locally against linked nextcloud-vue, custom reference widgets didn't load since we migrated to vite as builder and module bundler.
Apparently this was because webpack before didn't use modules but vite now does. So apparently the two vue dependencies from nextcloud-vue and text are suddenly treated as separate modules and have separate states.
Adding
vuetoresolve.dedupein the vite config solves, as it forces vite to only use vue from the root project (text).Fixes: #5958
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)