Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable27] Ignore pushes of update steps for read only sessions #6287

Merged
merged 1 commit into from
Sep 4, 2024
Merged

[stable27] Ignore pushes of update steps for read only sessions #6287

merged 1 commit into from
Sep 4, 2024

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud self-assigned this Aug 29, 2024
@luka-nextcloud luka-nextcloud changed the title fix: conflicts [stable27] Ignore pushes of update steps for read only sessions Aug 29, 2024
juliushaertl
juliushaertl requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the commit message to be the same as the original commit? Otherwise this will be very painful in case anyone needs to go through the git history

@luka-nextcloud luka-nextcloud force-pushed the backport/5895/stable27 branch 2 times, most recently from b3293fc to a625855 Compare September 3, 2024 17:34
@juliushaertl @luka-nextcloud
fix: Ignore pushes of update steps for read only sessions
b1ed889 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
max-nextcloud
max-nextcloud approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.
Thanks for taking care of this!

@mejo- mejo- disabled auto-merge September 4, 2024 09:26
@mejo- mejo- merged commit 5104e8d into stable27 Sep 4, 2024
56 checks passed
@mejo- mejo- deleted the backport/5895/stable27 branch September 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@mejo- mejo- Awaiting requested review from mejo-

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

Assignees

@luka-nextcloud luka-nextcloud

Labels
3. to review
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@luka-nextcloud @juliushaertl @max-nextcloud @mejo-