Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): switch action button to disabled state if results are empty #6799

Conversation

JuliaKirschenheuter
Copy link
Contributor

πŸ“ Summary

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
Screenshot from 2024-12-18 17-24-35 Screenshot from 2024-12-18 17-23-52

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 46.78%. Comparing base (8586891) to head (662e2c1).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6799      +/-   ##
==========================================
+ Coverage   46.76%   46.78%   +0.01%     
==========================================
  Files         748      740       -8     
  Lines       34162    34150      -12     
  Branches     1242     1234       -8     
==========================================
  Hits        15976    15976              
+ Misses      17564    17560       -4     
+ Partials      622      614       -8     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not test it but the change makes sense.

@max-nextcloud max-nextcloud merged commit 713ffb9 into main Dec 19, 2024
64 checks passed
@max-nextcloud max-nextcloud deleted the fix/6152-Show-assistant-results-does-not-have-any-results-shown-(emptycontent) branch December 19, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants