Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable31] fix/6871 smart add to next line #6916

Open
wants to merge 2 commits into
base: stable31
Choose a base branch
from
Open

[stable31] fix/6871 smart add to next line #6916

wants to merge 2 commits into from

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Feb 24, 2025

Backport of PR #6915

@max-nextcloud @backportbot
fix(vite): allow hostnames used for hmr via docker-dev
cb10911 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud @backportbot
fix(smart-picker): Add content on next line
4eaae6d 
Fixes #6871

Signed-off-by: Max <max@nextcloud.com>
@backportbot backportbot bot requested a review from juliusknorr February 24, 2025 16:31
@backportbot backportbot bot added design Experience, interaction, interface, … feature: formatting Features related to text formatting and node types 3. to review ux skill: frontend labels Feb 24, 2025
@backportbot backportbot bot added this to the Nextcloud 31 milestone Feb 24, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.52%. Comparing base (8305434) to head (4eaae6d).

Files with missing lines Patch % Lines
src/plugins/currentLineMenu.js 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           stable31    #6916      +/-   ##
============================================
+ Coverage     46.49%   46.52%   +0.02%     
============================================
  Files           750      735      -15     
  Lines         34663    34643      -20     
  Branches       1269     1254      -15     
============================================
  Hits          16118    16118              
+ Misses        17923    17918       -5     
+ Partials        622      607      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blizzz blizzz mentioned this pull request Feb 24, 2025
Merged
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 31.0.1 Feb 24, 2025
@blizzz blizzz mentioned this pull request Feb 24, 2025
Merged
juliusknorr
juliusknorr requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking until final is out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud max-nextcloud is a code owner

@mejo- mejo- Awaiting requested review from mejo- mejo- is a code owner

Assignees

@max-nextcloud max-nextcloud

Labels
3. to review design Experience, interaction, interface, … feature: formatting Features related to text formatting and node types skill: frontend ux
Projects
None yet
Milestone
Nextcloud 31.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @blizzz @max-nextcloud