Skip to content

chore(test): use retrying assertion #8170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
max-nextcloud merged 1 commit into from
Jan 19, 2026
+1 −1
Merged

chore(test): use retrying assertion #8170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion playwright/e2e/versions.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@
* @param editor editor section to inspect for headings
*/
async function checkVersions(versions: Locator, editor: EditorSection) {
expect(await versions.getByRole('link').count()).toBe(3)
expect(await versions.getByRole('link')).toHaveCount(3)
// the oldest version is at the end of the versions list
await versions.getByRole('link').nth(2).click()
await expect(editor.getHeading({ name: 'V1' })).toBeVisible()
Expand All @@ -83,5 +83,5 @@
await expect(editor.getHeading({ name: 'V2' })).toBeVisible()
// current version
await versions.getByRole('link').nth(0).click()
await expect(editor.getHeading({ name: 'V3' })).toBeVisible()

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 

  2) [chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:51:3

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 

  2) [chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:51:3

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 

  2) [chromium] › playwright/e2e/versions.spec.ts:49:3 › Versions with distant timestamps › Show up 
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:51:3

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 

  1) [chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 

    Retry #2 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:33:3

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 

  1) [chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:33:3

Check failure on line 86 in playwright/e2e/versions.spec.ts

View workflow job for this annotation

GitHub Actions / test

[chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 

  1) [chromium] › playwright/e2e/versions.spec.ts:27:3 › Versions with close timestamps › Show up separately 
    Error: expect(locator).toBeVisible() failed

    Locator: locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })
    Expected: visible
    Timeout: 5000ms
    Error: element(s) not found

    Call log:
      - Expect "toBeVisible" with timeout 5000ms
      - waiting for locator('.editor').first().getByRole('textbox').getByRole('heading', { name: 'V3' })


      84 | 	// current version
      85 | 	await versions.getByRole('link').nth(0).click()
    > 86 | 	await expect(editor.getHeading({ name: 'V3' })).toBeVisible()
         | 	                                                ^
      87 | }
      88 |
        at checkVersions (/home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:86:50)
        at /home/runner/actions-runner/_work/text/text/playwright/e2e/versions.spec.ts:33:3
}
Loading