only return rich workspace when depth is 1 or greater #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
the android app folder request is like the following:
by default:
depth:1
and includerich-workspace
tag, this will result in nextcloud checking rich workspace for every subfolder within the requested folder, in this request it istest_pictures
.here is the folder structure:
in each of the folder, there could be hundreads of files, it take some time to find the README.txt file. multiply this time for each of the 22 folders, i always get a timeout.
since the rich workspace file is for current folder, i don't see the necissity to get all of this for each subfolder , in the brower, they get this specifically using
https://localhost/ocs/v2.php/apps/text/workspace?path=/Photos