Fix app icon in light mode #38
Conversation
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
| @@ -43,7 +43,7 @@ public function getName(): string { | |||
| * @return string | |||
| */ | |||
| public function getIcon(): string { | |||
| return $this->urlgen->imagePath(Application::APP_ID, 'app.svg'); | |||
There was a problem hiding this comment.
Does this actually change anything? Is -dark some kind of magic string?
There was a problem hiding this comment.
The magic happens with the "fill" attribute on the <svg> tag. I always keep a dark and a light version just in case. You can get rid if the light one if you want.
There was a problem hiding this comment.
So, what does this fix? getIcon() used to return app.svg which was dark. Now it returns app-dark.svg which is dark.
There was a problem hiding this comment.
app.svg is used in the app list (app settings)
app-dark.svg must be used as the admin settings section icon.
Check those 2 places with dark and light theme and you'll see the icon color was wrong before and is ok now 😁 .
There was a problem hiding this comment.
Oof, magic file names... Thanks for this, then 💙
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
In the app list and in the admin setting section.