Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal settings UI is broken on Nextcloud 28 #494

Closed
st3iny opened this issue Nov 28, 2023 · 3 comments · Fixed by #495
Closed

Personal settings UI is broken on Nextcloud 28 #494

st3iny opened this issue Nov 28, 2023 · 3 comments · Fixed by #495
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature

Comments

@st3iny
Copy link
Member

st3iny commented Nov 28, 2023

Steps to reproduce

  1. Enroll a new device or try to toggle an existing one.

Expected behaviour

The action should be executed. On older sessions, the user should be asked for a password confirmation.

Actual behaviour

Nothing happens.

Problem

A password confirmation is requested for both actions and the installed version of @nextcloud/password-confirmation is not compatible with Nextcloud 28.

grafik

Ref https://github.com/nextcloud-libraries/nextcloud-password-confirmation#versions-compatibility

@st3iny st3iny added bug Something isn't working 1. to develop Accepted and waiting to be taken care of regression Regression of a previous working feature labels Nov 28, 2023
@ChristophWurst
Copy link
Member

Same as nextcloud/server#41760 (comment)?

@st3iny
Copy link
Member Author

st3iny commented Nov 28, 2023

This could be it. The incompatibility I mentioned was just a wild guess.

Well, the fix mentioned there wasn't backported so I'm gonna have to migrate this app to the default versioning scheme 🤡 (and release ASAP).

Ref nextcloud-libraries/nextcloud-password-confirmation#666


Browser log:

TypeError: Cannot read properties of undefined (reading '$el')
    at o.<anonymous> (index.mjs:35:24)
    at Array.<anonymous> (vue.runtime.esm.js:3143:20)
    at Mt (vue.runtime.esm.js:3065:16)

@st3iny
Copy link
Member Author

st3iny commented Nov 28, 2023

Well well, the app works without @nextcloud/vue 8 and @nextcloud/password-confirmation 5. I tested all the way down to Nextcloud 25 so we can keep a single branch for now.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 1. to develop Accepted and waiting to be taken care of labels Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants