fix: do not mount to hidden modal #666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
So it mounts the same as original NcModal. And make sure it overflows any siblings in body. Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Pytal
approved these changes
Nov 28, 2023
susnux
approved these changes
Nov 28, 2023
ShGKme
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See details in: nextcloud/server#41760 (comment)
So it mounts the same as original NcModal.
And make sure it overflows any siblings in body.
I'm not a fan of the current workaround, but IMO the best alternative is to provide some centralized method to work between popover components.