Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removed unused deprecated ILogger #638

Merged
merged 1 commit into from
Aug 26, 2024
Merged

chore: Removed unused deprecated ILogger #638

merged 1 commit into from
Aug 26, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 20, 2024

If we need a logger in the future we simply can use the PSR-3 LoggerInterface. But currently it is unused, so we do not need to dependency inject it.

If we need a logger in the future we simply can use the PSR-3 `LoggerInterface`.
But currently it is unused, so we do not need to dependency inject it.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from st3iny August 20, 2024 10:07
@susnux susnux added 3. to review Waiting for reviews techdebt labels Aug 20, 2024
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@st3iny st3iny merged commit 2d254d8 into main Aug 26, 2024
35 checks passed
@st3iny st3iny deleted the chore/drop-logger branch August 26, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews techdebt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants