Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ability to disable backup process within update #282

Closed
daniu-de opened this issue May 19, 2020 · 18 comments
Closed

ability to disable backup process within update #282

daniu-de opened this issue May 19, 2020 · 18 comments

Comments

@daniu-de
Copy link

everytime I update Nextcloud I get problems at the step "backup", Therefore I disable the step in the source code and have no issue updating. The first couple of times I was looking for solutions and found that lots of people have issues like that.

Now I found that this backup also consumes quite some space on my webspace

My provider is doing a perfect backup (database and program data) - better than Nextcloud could do it - rolling back Nextcloud would be way more complicated with the internal method than using my providers backup. In fact I rolled back Nextcloud quite often with my providers backup because the Nextcloud rollback did not work.

PLEASE give us a way to turn off backing up before doing an update - I - and for sure many others don't need it ...

@johkoenig
Copy link
Member

@daniu-de until this is fixed, could you please tell us which lines have to be removed to skip the backup?

@MorrisJobke
Copy link
Member

@daniu-de until this is fixed, could you please tell us which lines have to be removed to skip the backup?

For the web updater:

updater/index.php

Line 1345 in cbf2b53

$updater->createBackup();

@johkoenig
Copy link
Member

@MorrisJobke thanks!
I'm looking for the same on the command line updater.

As an idea for the command line updater: An option like "--no-backup" would be great!

@MorrisJobke
Copy link
Member

@MorrisJobke thanks!
I'm looking for the same on the command line updater.

As an idea for the command line updater: An option like "--no-backup" would be great!

cc @kesselb ;)

@MorrisJobke
Copy link
Member

As an idea for the command line updater: An option like "--no-backup" would be great!

19.0.4, 18.0.10 and 17.0.10 will contain it. See #292

I don't plan to add this to the web UI as of now.

@daniu-de
Copy link
Author

that is not userfriendly at all. Everybody who has a decent backup does NOT NEED that annoying backup that just fills up space on the harddrive. Just forgot to disable the backup again and will spend lots of time deleting it since I do not have proper access to the server and ftp gets disconnected all the time ...

@Moilleadoir
Copy link

Updates just don’t work without this.

@william-e
Copy link

Hi Morris,
could you please reconsider, I find it very annoying too ...

@a-ly
Copy link

a-ly commented Aug 13, 2021

I think in modern installations one really does need the ability to disable the backup... Who still uses file systems without snapshots in 2021? A Snapshot takes less than a second, the backup in the update takes forever and is less useful.

@kesselb
Copy link
Contributor

kesselb commented Aug 13, 2021

I think in modern installations one really does need the ability to disable the backup... Who still uses file systems without
snapshots in 2021? A Snapshot takes less than a second, the backup in the update takes forever and is less useful.

@a-ly You know that the updater has support to skip backup on the command line?

@a-ly
Copy link

a-ly commented Aug 13, 2021

I think in modern installations one really does need the ability to disable the backup... Who still uses file systems without
snapshots in 2021? A Snapshot takes less than a second, the backup in the update takes forever and is less useful.

@a-ly You know that the updater has support to skip backup on the command line?

@kesselb yes, but not everybody has access to command line, but can take a snapshot. Why not have that option in the web interface?

@kesselb
Copy link
Contributor

kesselb commented Aug 13, 2021

Why not have that option in the web interface?

I don't think there is a technically reason to not have such an option in the web based updater. I'm not going to build it as the cli option is good enough for me and I don't care much about users without shell access. As you said it's 2021 - who uses a shared hosting without ssh access? ;)

@jackrsteiner
Copy link

I'm wondering if there's an option that's the inverse of --no-backup? Like, if you don't want updater to run, but just want the updater step 3 to run, is there an occ or updater command for this already? I think this is sort of a necessary compliment to updater --no-backup, even if the operation is trivial.

@daniu-de
Copy link
Author

I currently don't have access to a shell and since this seems to be so unwanted I keep editing the file updater.php (?) which is much easier than leading that useless discussion here. I don't like the fact that the programmers are so ignorant though ...
Had been thinking about writing some script that does it for me - I could do that - adding the feature is beyond me unfortunately

The point for me (no shell access) is also that it takes ages (I guess half an hour with a good ftp programm is not enough) to delete that space consuming, unnecessary backup since fast commands are not available for me ...

@linuxmangr
Copy link

linuxmangr commented Jul 21, 2023

@daniu-de until this is fixed, could you please tell us which lines have to be removed to skip the backup?

For the web updater:

updater/index.php

Line 1345 in cbf2b53

$updater->createBackup();

Thank you very match, you save my time.
Is very useful solution.

@Jolopu
Copy link

Jolopu commented Mar 29, 2024

This solution only works for the next update. Then index.php gets replaced. It would be nice to have an entry in the config file to disable these backups one and for all.

@hregis
Copy link

hregis commented Sep 7, 2024

Still no option to decide whether or not to have a backup during an upgrade?
Why impose this???
Please consider this request

@Jolopu
Copy link

Jolopu commented Sep 7, 2024

Yes, please. I always have to delete theses unnecessary backups after each update. It's just a waste of valuable server space.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests