Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI only] Add option to skip backup. #292

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 23, 2020

No description provided.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselb kesselb changed the title Add option to skip backup. [CLI only] Add option to skip backup. Jul 23, 2020
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason this is a draft?

@kesselb
Copy link
Contributor Author

kesselb commented Jul 23, 2020

Any reason this is a draft?

Untested yet. I will build it later and use it to update my production instance.

@kesselb kesselb marked this pull request as ready for review July 24, 2020 12:34
@kesselb
Copy link
Contributor Author

kesselb commented Jul 24, 2020

Works on My Machine.

@MorrisJobke MorrisJobke merged commit 2accb2a into master Jul 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the enh/noid/skip-backup branch July 30, 2020 12:04
@MorrisJobke
Copy link
Member

/backport to stable19

@MorrisJobke
Copy link
Member

/backport to stable18

@MorrisJobke
Copy link
Member

/backport to stable17

@MorrisJobke
Copy link
Member

Will be shipped in 19.0.2, 18.0.8 and 17.0.9.

@solracsf
Copy link
Member

@kesselb @MorrisJobke this command doesn't output in 19.0.2:

php ./updater/updater.phar --help

Usage:
  update

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Help:
  This command fetches the latest code that is announced via the updater server and safely replaces the existing code with the new one.

@MorrisJobke
Copy link
Member

Ooops .... we forgot to build the phar.

@MorrisJobke
Copy link
Member

Next releases will contain it. Or you just download it from this repo and place it in the updater folder manually.

@MorrisJobke
Copy link
Member

Next releases will contain it. Or you just download it from this repo and place it in the updater folder manually.

19.0.4, 18.0.10 and 17.0.10

@jackrsteiner
Copy link

I'm wondering if there's an option that's the inverse of --no-backup? Like, if you don't want updater to run, but just want the updater step 3 to run, is there an occ or updater command for this already? I think this is sort of a necessary compliment to updater --no-backup.

@joshtrichards
Copy link
Member

@jackrsteiner No there isn't. I doubt there will be within the Updater itself. The backup functionality here is more intended for the Updater's own use. It's not backing up your data directory (files) nor your database. It's just the installation files (well, and your config/ folder).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants