Skip to content

expect dist directory #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2022
Merged

expect dist directory #411

merged 1 commit into from
Mar 31, 2022

Conversation

@blizzz
Copy link
Member

@blizzz blizzz commented Mar 31, 2022

No description provided.

@blizzz
expect dist directory
baf28ae 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the bug label Mar 31, 2022
PVince81
PVince81 approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blizzz blizzz merged commit 1d775f7 into master Mar 31, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/expect-dist branch March 31, 2022 19:14
@szaimen
Copy link
Contributor

szaimen commented Apr 2, 2022

@blizzz @PVince81 @skjnldsv shouldn't this also be adjustes here:

updater/index.php

Line 317 in ae1d6fb

private function getExpectedElementsList() {
?

@szaimen szaimen mentioned this pull request Apr 3, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Apr 3, 2022

#412

@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PVince81 PVince81 PVince81 approved these changes

@CarlSchwan CarlSchwan CarlSchwan approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees

No one assigned

Labels

3. to review bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@blizzz @szaimen @PVince81 @CarlSchwan