Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 4.0 broke support for PHP 7.4 on NC25 #420

Closed
tcitworld opened this issue May 17, 2023 · 2 comments
Closed

Release 4.0 broke support for PHP 7.4 on NC25 #420

tcitworld opened this issue May 17, 2023 · 2 comments
Assignees
Labels
bug Something isn't working regression Regression of a previous working feature

Comments

@tcitworld
Copy link
Member

tcitworld commented May 17, 2023

Nextcloud 25 oldest supported PHP version is PHP 7.4.

#402 and #408 make use of PHP8.0+ exclusive syntax.

Moreover, because of the signature change introduced in nextcloud/server#38104, it's not possible to have a release which is compatible with both 25 (with 7.4 compatibility) and 27.

Therefore I suggest to make another 4.0.1 release with PHP8.0+ syntax removed to fix 25 instances, then bump to 5.0.0 for a 26+ exclusive release. You can find such code in branch fix-nc25-php7.4-compat (but it's not compatible with 27 !)

Otherwise we can have a 4.0.1 release based on stable25's code, but it will miss changes from 4.0.0. :s

Ref: https://help.nextcloud.com/t/error-after-updating-to-version-25-0-6-1/162279

@Pytal @come-nc

@tcitworld tcitworld added bug Something isn't working regression Regression of a previous working feature labels May 17, 2023
tcitworld added a commit that referenced this issue May 17, 2023
Closes #420

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@Pytal Pytal self-assigned this May 18, 2023
@Pytal
Copy link
Member

Pytal commented May 18, 2023

Thanks for the heads up @tcitworld!

Closed by #424

@Pytal Pytal closed this as completed May 18, 2023
@Pytal
Copy link
Member

Pytal commented May 18, 2023

NC25 + 26 compatible version is v3.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

2 participants