Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add selective data export to CLI #167

Merged
merged 9 commits into from
May 31, 2022
Merged

Add selective data export to CLI #167

merged 9 commits into from
May 31, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented May 26, 2022

Close #94

Description:
  Export a user.

Usage:
  user:export [options] [--] [<user> [<folder>]]

Arguments:
  command               The command to execute
  user                  user to export
  folder                local folder to export into

Options:
  -l, --list[=LIST]     List the available data types, pass --list=full to show more information [default: false]
  -t, --types=TYPES     Comma-separated list of data type ids, pass --types=none to only export base user data [default: false]
  -h, --help            Display this help message

Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews enhancement New feature request labels May 26, 2022
@Pytal Pytal added this to the 1.1 milestone May 26, 2022
@Pytal Pytal requested review from come-nc and a team May 26, 2022 01:48
@Pytal Pytal self-assigned this May 26, 2022
@Pytal Pytal requested review from icewind1991 and blizzz and removed request for a team May 26, 2022 01:48
@Pytal
Copy link
Member Author

Pytal commented May 26, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label May 26, 2022
Pytal added 6 commits May 26, 2022 17:51
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Copy link
Collaborator

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test, will do tomorrow hopefully.

Pytal added 2 commits May 31, 2022 01:41
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal requested a review from come-nc May 31, 2022 01:46
@come-nc
Copy link
Collaborator

come-nc commented May 31, 2022

The help does not match behavior:

Usage:
  user:export [options] [--] [<user> [<folder>]]
occ user:export bob
                                                                                                                        
 [ERROR] Missing folder argument       

This cannot be fixed easily I think

Copy link
Collaborator

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How hard would it be to add an --ouput option like core commands to get the list in json format?

@come-nc
Copy link
Collaborator

come-nc commented May 31, 2022

(tested and works, you can merge)

@Pytal
Copy link
Member Author

Pytal commented May 31, 2022

The help does not match behavior:

This cannot be fixed easily I think

Not with the existing symfony console framework, errors are thrown as needed to inform the user

How hard would it be to add an --ouput option like core commands to get the list in json format?

Will be tracked in #170

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 31, 2022
@Pytal Pytal merged commit c660e09 into main May 31, 2022
@Pytal Pytal deleted the feat/cli-selective-export branch May 31, 2022 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement New feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow selective export on occ
2 participants