Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cancel button while cancelling #358

Merged
merged 1 commit into from
Feb 17, 2023
Merged

Disable cancel button while cancelling #358

merged 1 commit into from
Feb 17, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Feb 16, 2023

Prevent additional cancel requests while cancellation is in progress

Screenshot
Before image
After image

Signed-off-by: Christopher Ng <chrng8@gmail.com>
(cherry picked from commit 9ca72cb)
@Pytal Pytal added 3. to review Waiting for reviews bug Something isn't working labels Feb 16, 2023
@Pytal Pytal added this to the 3.0 milestone Feb 16, 2023
@Pytal Pytal requested review from artonge and come-nc February 16, 2023 00:21
@Pytal Pytal self-assigned this Feb 16, 2023
@Pytal
Copy link
Member Author

Pytal commented Feb 16, 2023

This can probably just go in for v3 as v3 will still support 25 @come-nc?

@Pytal Pytal mentioned this pull request Feb 16, 2023
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 17, 2023
@Pytal Pytal merged commit 0adf454 into main Feb 17, 2023
@Pytal Pytal deleted the fix/disable-cancel branch February 17, 2023 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants