Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PKCE support #697

Merged
merged 2 commits into from
Nov 24, 2023
Merged

Add PKCE support #697

merged 2 commits into from
Nov 24, 2023

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Oct 27, 2023

For the providers that support it. Add extra security. See also https://datatracker.ietf.org/doc/html/rfc7636

closes #344 #710

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

rullzer and others added 2 commits November 24, 2023 12:31
For the providers that support it. Add extra security.
See also https://datatracker.ietf.org/doc/html/rfc7636

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Florian Klinger <florian.klinger@nextcloud.com>
Copy link
Contributor

@nc-fkl nc-fkl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @rullzer for your commit, i fixed a typo and rebased on main

@nc-fkl nc-fkl merged commit 9abb62d into main Nov 24, 2023
41 checks passed
@nc-fkl nc-fkl deleted the add_pkce branch November 24, 2023 11:40
@julien-nc julien-nc mentioned this pull request Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for PKCE
2 participants