Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken details sidebar due to double URL encoded path #1465

Closed
Tracked by #1280
XueSheng-GIT opened this issue Nov 6, 2022 · 5 comments · Fixed by #1470
Closed
Tracked by #1280

Broken details sidebar due to double URL encoded path #1465

XueSheng-GIT opened this issue Nov 6, 2022 · 5 comments · Fixed by #1470
Labels
3. to review Waiting for reviews bug Something isn't working

Comments

@XueSheng-GIT
Copy link

XueSheng-GIT commented Nov 6, 2022

Describe the bug
Opening text does break the details side bar (empty content, sometimes not visible, sometimes visible, but completely empty).

To Reproduce
Steps to reproduce the behaviour:

  1. Open details sidebar of a markdown (text) file.
  2. Click on the text file to open it
  3. Close details sidebar
  4. Click "3-dots" and "Open sidebar" to open sidebar again

Expected behaviour
Sidebar content should be visible if sidebar is opened (step 2 and 4 above).

Screenshots
Broken sidebar.webm

Client details:

  • OS: Ubuntu 22.04
  • Browser: Firefox
  • Version: 106.0.2
  • Device: Desktop
Server details

Text app version: 3.6.0

Operating system: Ubuntu 20.04

Web server: apache2 (2.4.54)

Database: mariadb (Ver 15.1 Distrib 10.3.34-MariaDB)

PHP version: 7.4.32

Nextcloud version: 25.0.1

@XueSheng-GIT XueSheng-GIT added the bug Something isn't working label Nov 6, 2022
@mejo-
Copy link
Member

mejo- commented Nov 9, 2022

Might this be related to the focus-trap issues we have in Nextcloud 25?

@mejo- mejo- added the 0. Needs triage Pending approval or rejection. This issue is pending approval. label Nov 9, 2022
@juliushaertl
Copy link
Member

Can you maybe tell if your folder/filename has a space or special characters and if it does not happen with just a Readme.md in the root directory?

@XueSheng-GIT
Copy link
Author

You are right. It does work for "Readme.md" and breaks as soon as a space or special character is added to the Filename!

@juliushaertl
Copy link
Member

Moving to viewer since the file actions and sidebar handling is happening over there.

@juliushaertl juliushaertl transferred this issue from nextcloud/text Nov 14, 2022
@juliushaertl
Copy link
Member

@skjnldsv It seems there is some double encoding again when trying to open the sidebar from viewer (e.g. with a file path that contains spaces). Any idea what change might have caused this for 25?

@juliushaertl juliushaertl changed the title Broken details sidebar Broken details sidebar due to double URL encoded path Nov 14, 2022
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants