Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing localization in edit view #2578

Closed
Ivansss opened this issue Sep 30, 2024 · 1 comment · Fixed by #2589
Closed

Missing localization in edit view #2578

Ivansss opened this issue Sep 30, 2024 · 1 comment · Fixed by #2589
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@Ivansss
Copy link
Member

Ivansss commented Sep 30, 2024

There are some missing translations in edit view.

The discard changes dialog:

discard-changes-dialog

https://github.com/scaleflex/filerobot-image-editor/blob/742946660496fa4dc689ca6b308571be01fc1555/packages/react-filerobot-image-editor/src/context/defaultTranslations.js#L11

The "Annotate" button:

annotate-button
@Ivansss Ivansss added bug Something isn't working 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Sep 30, 2024
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Oct 1, 2024
@szaimen
Copy link
Contributor

szaimen commented Oct 1, 2024

I could reproduce on the stable28 branch

@susnux susnux moved this to 📄 To do (~10 entries) in 📁 Files team Oct 14, 2024
@Ivansss Ivansss mentioned this issue Oct 14, 2024
Merged
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team Oct 15, 2024
artonge added a commit that referenced this issue Dec 2, 2024
@artonge
fix(Editor): Broken translation ref
f5a6aa2 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge mentioned this issue Dec 2, 2024
Merged
backportbot bot pushed a commit that referenced this issue Dec 3, 2024
@artonge @backportbot
fix(Editor): Broken translation ref
02d68d7 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
backportbot bot pushed a commit that referenced this issue Dec 3, 2024
@artonge @backportbot
fix(Editor): Broken translation ref
f8b21b5 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
backportbot bot pushed a commit that referenced this issue Dec 3, 2024
@artonge @backportbot
fix(Editor): Broken translation ref
4d04bc9 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
skjnldsv pushed a commit that referenced this issue Dec 14, 2024
@artonge @skjnldsv
fix(Editor): Broken translation ref
ffb542a 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
skjnldsv pushed a commit that referenced this issue Dec 14, 2024
@artonge @skjnldsv
fix(Editor): Broken translation ref
038e96a 
Regression from #2578

Signed-off-by: Louis Chemineau <louis@chmn.me>

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
📁 Files team
Status: ☑️ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Update default editor translations for version 4.8.1 nextcloud/viewer
2 participants
@Ivansss @szaimen