Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use viewer for single files sharing too #644

Closed
skjnldsv opened this issue Oct 11, 2020 · 5 comments
Closed

Use viewer for single files sharing too #644

skjnldsv opened this issue Oct 11, 2020 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of discussion Being discussed enhancement New feature or request
Milestone
Nextcloud 25

Comments

@skjnldsv
Copy link
Member

Should be doable if we just don't show the modal I guess?

@juliushaertl thoughts? Would text work out of the box?
@skjnldsv skjnldsv added enhancement New feature or request 1. to develop Accepted and waiting to be taken care of discussion Being discussed labels Oct 11, 2020
@Lion767

This comment was marked as off-topic.

Sign in to view
@juliusknorr
Copy link
Member

@skjnldsv Yep, should work as long as the props of the registered components don't change. Though I can imagine we need some fixes of the styling on the text app side as well.

@skjnldsv

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv mentioned this issue Nov 1, 2020
Closed
@skjnldsv skjnldsv mentioned this issue Dec 10, 2020
Open
@skjnldsv skjnldsv mentioned this issue May 28, 2021
Closed
This was referenced Aug 6, 2021
Open
Merged
@menaceone
Copy link

menaceone commented Feb 11, 2022 •
edited
Loading

Hence the original Video Player is deprecated (nextcloud/files_videoplayer/issues/201) this feature is really important.
Sharing a single Video is a very common usecase and only possible with the old Video Player app.

@max-nextcloud max-nextcloud mentioned this issue Jul 25, 2022
Merged
@szaimen
Copy link
Contributor

szaimen commented Sep 27, 2022

done with NC25

@szaimen szaimen closed this as completed Sep 27, 2022
@szaimen szaimen added this to the Nextcloud 25 milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop Accepted and waiting to be taken care of discussion Being discussed enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 25
Development

No branches or pull requests
5 participants
@juliusknorr @menaceone @skjnldsv @szaimen @Lion767