Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling conflict with Gallery previewer, files_videoviewer etc #3

Closed
jancborchardt opened this issue Feb 22, 2019 · 10 comments
Closed
Labels
discussion Being discussed

Comments

@jancborchardt
Copy link
Member

So eventually this viewer should be the default viewer for all sorts of formats. Right now the Gallery app is taking precedence still.

Should we:

  • Disable the slideshow module of Gallery so that the viewer app is used?
  • Continue work on it and do that for 17
  • Something else?

Basically, when someone has Gallery and Videoviewer enabled but not Viewer, those apps should of course do the previews. But if you have Viewer enabled, this app should take over.

@jancborchardt jancborchardt added the discussion Being discussed label Feb 22, 2019
@jancborchardt
Copy link
Member Author

cc @nextcloud/javascript for that too. :)

@skjnldsv
Copy link
Member

I'd say, deprecate the gallery and stop shipping in 3 versions?
I can add a warning or maybe even a check so that admins can't enable the viewer app if the gallery is enabled?

@jancborchardt
Copy link
Member Author

As mentioned, I was under the impression we want to keep the Gallery and extend its functionality? With stuff like EXIF info, proper sidebar, editing info etc.

Every platform has an actual photo app. Files is Finder, but Gallery is iPhoto.

What do you think @MorrisJobke @rullzer?

@jancborchardt
Copy link
Member Author

In any case I think it’s a slightly different discussion. Right now already, the viewer app should take precedence over gallery and files_videoviewer et al.

@skjnldsv
Copy link
Member

@jancborchardt Okay, let's focus on matching existing slideshow/viewer features of other apps and deprecate them.

  • files_videoviewer does only open video in a player like we currently do, right?
  • gallery do the same for images (+ livephotos support that is currently not merged?)
  • anything else?

@juliusknorr
Copy link
Member

files_videoviewer does only open video in a player like we currently do, right?

It also takes care of displaying videos on public pages, so as long as the viewer doesn't take care of that we should make it possible to have both installed.

Maybe we can for now just add some check to the gallery/files_videoplayer to not register a file handler if the viewer app is installed.

@J0WI
Copy link

J0WI commented Oct 31, 2020

It also takes care of displaying videos on public pages, so as long as the viewer doesn't take care of that we should make it possible to have both installed.

I guess this is fixed since #408

@skjnldsv
Copy link
Member

skjnldsv commented Nov 1, 2020

No still missing single file view
#644

@szaimen
Copy link
Contributor

szaimen commented Sep 27, 2022

done with NC25

@szaimen szaimen closed this as completed Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Being discussed
Projects
None yet
Development

No branches or pull requests

5 participants