Public pages compatibility #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
added
2. developing
skjnldsv
commented
Feb 28, 2020
This comment has been minimized.
This comment has been minimized.
skjnldsv
requested review from
juliusknorr,
gary-kim,
ChristophWurst,
jospoortvliet and
rullzer
|
Works fine! Please test with nextcloud/server#19777 I forgot to stop listening to LoadAdditionalScriptsEvent like we do with the LoadSidebar event. This is enough :) |
juliusknorr
reviewed
Mar 4, 2020
ChristophWurst
approved these changes
Mar 4, 2020
skjnldsv
force-pushed
the
enh/public
branch
2 times, most recently
from
c60460d to
0aa1ca3
Compare
|
/compile amend / |
skjnldsv
added
4. to release
npmbuildbot-nextcloud
bot
force-pushed
the
enh/public
branch
from
0aa1ca3 to
a26e7e8
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
ChristophWurst
approved these changes
Mar 6, 2020
|
/backport to stable18 |
backportbot-nextcloud
bot
added
the
backport-request
|
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
npmbuildbot-nextcloud
bot
force-pushed
the
enh/public
branch
from
d67331a to
a0b40d0
Compare
|
The backport to stable18 failed. Please do this backport manually. |
|
backport in #422 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #89
Use it with nextcloud/server#19777