Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable swiping on viewer audio controls #1121

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Disable swiping on viewer audio controls #1121

merged 1 commit into from
Jan 5, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jan 4, 2022

See #1113

@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews labels Jan 4, 2022
@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Jan 4, 2022
@skjnldsv skjnldsv requested review from juliusknorr, Pytal, a team, PVince81 and artonge and removed request for a team January 4, 2022 06:39
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 4, 2022

/backport to stable23

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Jan 4, 2022
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 4, 2022

/backport to stable22

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 4, 2022

/backport to stable21

@skjnldsv skjnldsv mentioned this pull request Jan 4, 2022
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 4, 2022

/compile amend /

@skjnldsv @nextcloud-command
Disable swiping on viewer audio controls
ffb53c0 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/disable-swiping-controls-audio branch from 6524f72 to ffb53c0 Compare January 4, 2022 06:41
@Pytal
Copy link
Member

Pytal commented Jan 5, 2022

CI unhappy

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 5, 2022 •
edited
Loading

Seems like a false negative

The following error originated from your application code, not from Cypress.

  > OC is not defined

EDIT: Can't reproduce the issue 🤔

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2022
@skjnldsv skjnldsv merged commit 3b12e91 into master Jan 5, 2022
@skjnldsv skjnldsv deleted the fix/disable-swiping-controls-audio branch January 5, 2022 08:27
This was referenced Jan 5, 2022
Merged
Merged
Merged
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@artonge artonge artonge approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working
Projects
None yet
Milestone
Nextcloud 24
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @Pytal @juliusknorr @artonge