-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable opening a single shared file #1242
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
4b1596e
enable opening a single shared file
vanpertsch 8c58437
render viewer content in element instead of modal
max-nextcloud cacc56c
disable zooming for single shared file
vanpertsch 4b9605b
test: basic cypress test for single file share
max-nextcloud bba1ae4
fix: keep body overflow when rendering in element
max-nextcloud 19921a9
build: js
max-nextcloud File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
/** | ||
* @copyright Copyright (c) 2022 Max <max@nextcloud.com> | ||
* | ||
* @author Max <max@nextcloud.com> | ||
* | ||
* @license AGPL-3.0-or-later | ||
* | ||
* This program is free software: you can redistribute it and/or modify | ||
* it under the terms of the GNU Affero General Public License as | ||
* published by the Free Software Foundation, either version 3 of the | ||
* License, or (at your option) any later version. | ||
* | ||
* This program is distributed in the hope that it will be useful, | ||
* but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
* GNU Affero General Public License for more details. | ||
* | ||
* You should have received a copy of the GNU Affero General Public License | ||
* along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
* | ||
*/ | ||
|
||
import { randHash } from '../utils/' | ||
const randUser = randHash() | ||
|
||
describe('See shared folder with link share', function() { | ||
let imageToken | ||
let videoToken | ||
|
||
before(function() { | ||
cy.nextcloudCreateUser(randUser, 'password') | ||
cy.login(randUser, 'password') | ||
cy.uploadFile('image1.jpg', 'image/jpeg') | ||
cy.uploadFile('video1.mp4', 'video/mp4') | ||
cy.createLinkShare('/image1.jpg').then(token => imageToken = token) | ||
cy.createLinkShare('/video1.mp4').then(token => videoToken = token) | ||
cy.logout() | ||
}) | ||
|
||
|
||
it('opens the shared image in the viewer', function() { | ||
cy.visit(`/s/${imageToken}`) | ||
cy.get('#imgframe img').should('be.visible') | ||
cy.get('#imgframe > #viewer').should('be.visible') | ||
cy.scrollTo('bottom') | ||
cy.get('a#downloadFile').should('be.visible') | ||
}) | ||
|
||
it('opens the shared video in the viewer', function() { | ||
cy.visit(`/s/${videoToken}`) | ||
cy.get('#imgframe .plyr').should('be.visible') | ||
cy.get('#imgframe > #viewer').should('be.visible') | ||
cy.scrollTo('bottom') | ||
cy.get('a#downloadFile').should('be.visible') | ||
}) | ||
}) |
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@max-nextcloud We can load a single file without being inline.
This is a regression
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. I'll fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So i guess a good criterion will be if
el
is set.