Expose handler to allow CSS selectors #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
previously requested changes
Jul 7, 2022
|
@skjnldsv Please check discussions on this PR: |
I should have been mentioned in the other thread 🤷 |
luka-nextcloud
force-pushed
the
feature/improve-header-bar
branch
from
e63d45d to
85b42ca
Compare
juliusknorr
reviewed
Jul 18, 2022
src/views/Viewer.vue
Outdated
| @@ -25,8 +25,9 @@ | |||
| <Modal v-if="initiated || currentFile.modal" | |||
| id="viewer" | |||
| size="full" | |||
| :class="{'icon-loading': !currentFile.loaded && !currentFile.failed, | |||
| 'theme--undefined': theme === null, 'theme--dark': theme === 'dark', 'theme--light': theme === 'light', 'theme--default': theme === 'default'}" | |||
| :class="[{'icon-loading': !currentFile.loaded && !currentFile.failed, | |||
There was a problem hiding this comment.
Make we can move this to a computed property to make it more readable :)
juliusknorr
reviewed
Jul 18, 2022
src/views/Viewer.vue
Outdated
| 'theme--undefined': theme === null, 'theme--dark': theme === 'dark', 'theme--light': theme === 'light', 'theme--default': theme === 'default'}" | ||
| :class="[{'icon-loading': !currentFile.loaded && !currentFile.failed, | ||
| 'theme--undefined': theme === null, 'theme--dark': theme === 'dark', | ||
| 'theme--light': theme === 'light', 'theme--default': theme === 'default'}, `app-${handlerId}`]" |
There was a problem hiding this comment.
I'd prefer to set a data attribute like :data-handler="handlerId" as the handler id might also contain characters that are not supported in css selector classes
There was a problem hiding this comment.
I agree, it will be more future-proof and prevents CSS conflicts.
jancborchardt
approved these changes
Jul 18, 2022
1 task
luka-nextcloud
force-pushed
the
feature/improve-header-bar
branch
from
85b42ca to
e4062b2
Compare
juliusknorr
approved these changes
Jul 20, 2022
|
/compile amend / |
Signed-off-by: Luka Trovic <luka@nextcloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
feature/improve-header-bar
branch
from
e4062b2 to
f52dc17
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nextcloud/text#2440