Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle 404 when opening files #1543

Merged
merged 1 commit into from
Feb 27, 2023
Merged

handle 404 when opening files #1543

merged 1 commit into from
Feb 27, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Feb 7, 2023 •
edited
Loading

Bug reproduction:

  1. Login with 2 distinct accounts. account a and b
  2. share a file from account a to b
  3. make sure you see the file on account b and keep the page open
  4. unshare the file and don't refresh the account b's page
  5. open the file from account b

a 404 error will get logged in the console but the viewer will get stuck at loading

Signed-off-by: hamza221 hamzamahjoubi221@gmail.com

@hamza221 hamza221 added bug Something isn't working enhancement New feature or request 3. to review Waiting for reviews labels Feb 7, 2023
@hamza221 hamza221 force-pushed the fix/unshared-removed-files-opening branch from fff1c09 to f7b2559 Compare February 7, 2023 16:58
@szaimen szaimen added this to the Nextcloud 26 milestone Feb 7, 2023
@szaimen szaimen requested review from ChristophWurst, skjnldsv, a team, Pytal and szaimen and removed request for a team February 7, 2023 17:53
@szaimen szaimen closed this Feb 7, 2023
@szaimen szaimen reopened this Feb 7, 2023
ChristophWurst
ChristophWurst approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense and code looks good

@ChristophWurst
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Feb 8, 2023
@ChristophWurst
Copy link
Member

/backport to stable24

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 8, 2023
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@skjnldsv
Copy link
Member

Please rebase and compile again :)

@hamza221 hamza221 force-pushed the fix/unshared-removed-files-opening branch 2 times, most recently from d08251b to 5462934 Compare February 27, 2023 09:05
@ChristophWurst
Copy link
Member

/compile amend /

@hamza221 @nextcloud-command
handle 404 when openning files
de21386 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the fix/unshared-removed-files-opening branch from 5462934 to de21386 Compare February 27, 2023 09:19
@ChristophWurst ChristophWurst merged commit d34338a into master Feb 27, 2023
@ChristophWurst ChristophWurst deleted the fix/unshared-removed-files-opening branch February 27, 2023 09:46
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Feb 27, 2023
Merged
1 task
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@Pytal Pytal Awaiting requested review from Pytal Pytal was automatically assigned from nextcloud/server-frontend

@szaimen szaimen Awaiting requested review from szaimen szaimen was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@hamza221 @ChristophWurst @skjnldsv @szaimen