Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override hardcoded save button width #1656

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 11, 2023

The save button wrapper have a fixed width: https://github.com/scaleflex/filerobot-image-editor/blob/775f3cbc827755fda0f067265719df0787b355c8/packages/react-filerobot-image-editor/src/components/Topbar/SaveButton.jsx#L31

This PR override this hardcoded value to give it more flexibility.

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge enabled auto-merge May 11, 2023 14:21
@artonge artonge self-assigned this May 11, 2023
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels May 11, 2023
@artonge artonge added this to the Nextcloud 27 milestone May 11, 2023
@artonge
Copy link
Contributor Author

artonge commented May 11, 2023

/backport to stable26

@artonge
Copy link
Contributor Author

artonge commented May 11, 2023

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label May 11, 2023
@artonge artonge merged commit 4452c11 into master May 11, 2023
@artonge artonge deleted the artonge/fix/save_button_width branch May 11, 2023 19:06
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button "Save" & "Reset" get on top of each other in Photo app
2 participants