Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fullscreen on ios #1819

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix fullscreen on ios #1819

merged 1 commit into from
Jul 17, 2023

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Jul 17, 2023 •
edited
Loading

Fixes #1681
image
image

@hamza221
fix fullscreen on ios
603af2d 
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
@hamza221 hamza221 added bug Something isn't working 3. to review Waiting for reviews labels Jul 17, 2023
@hamza221 hamza221 self-assigned this Jul 17, 2023
@hamza221 hamza221 requested a review from artonge July 17, 2023 12:44
@JuliaKirschenheuter
Copy link
Contributor

failing cypress: #1763 (comment)
#1763 (comment)

@blizzz blizzz merged commit cf1ab10 into master Jul 17, 2023
@blizzz blizzz deleted the fix/fullscreen-ios branch July 17, 2023 14:24
This was referenced Jul 17, 2023
Closed
Merged
Merged
Merged
@github-actions
Copy link

github-actions bot commented Aug 1, 2023

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the reviewing process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR reviewing process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@artonge artonge mentioned this pull request Jul 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@st3iny st3iny Awaiting requested review from st3iny

@artonge artonge Awaiting requested review from artonge

@Ivansss Ivansss Awaiting requested review from Ivansss

Assignees

@hamza221 hamza221

Labels
3. to review Waiting for reviews bug Something isn't working feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Video player is unusable on ios (firefox and safari) since update to 25
3 participants
@hamza221 @JuliaKirschenheuter @blizzz