feat: Save current state of a file before downloading it #3001
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @silverkszlo is this a bug? feat? Please add labels + milestone accordingly :) |
Hey @skjnldsv , yes, sorry, this PR is still a draft, all the necessary information are incoming 🙏 |
silverkszlo
changed the title
Signed-off-by: silver <s.szmajduch@posteo.de>
silverkszlo
force-pushed
the
save-file-before-download
branch
from
80c3e53 to
740cf53
Compare
Signed-off-by: silver <s.szmajduch@posteo.de>
silverkszlo
added
3. to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/issues/assigned?issue=nextcloud-gmbh%7Ccustomer-feature-requests%7C1059
Before:
When editing a markdown document online in files and download it from the editor/viewer without saving it manually, the last saved version is downloaded. The last saved version may not include what was just added/edited after the previous
saveoperation. So the downloaded file may differ from the file one sees online.Now:
Clicking on
Downloadnow triggers an automaticsaveoperation of the document. If the saving for some reason fails, the last saved version is still being downloaded.