-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
React to sidebar events from nextcloud-bus #913
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
2 times, most recently
from
May 26, 2021 16:34
d1e526c
to
b061a2e
Compare
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
from
May 26, 2021 16:39
b061a2e
to
225b822
Compare
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
2 times, most recently
from
May 27, 2021 15:53
d602602
to
bf9bdfc
Compare
skjnldsv
reviewed
May 27, 2021
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
11 times, most recently
from
May 31, 2021 15:51
9e1e4ff
to
89a18a6
Compare
artonge
changed the title
React to sidebar events
React to sidebar events from nextcloud-bus
May 31, 2021
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
from
May 31, 2021 16:53
89a18a6
to
c25d68e
Compare
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
2 times, most recently
from
June 8, 2021 09:40
d7ff8a2
to
74dfc5f
Compare
59 tasks
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
from
June 10, 2021 08:55
74dfc5f
to
d3a61e1
Compare
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
3 times, most recently
from
June 10, 2021 13:36
cab063f
to
2d25756
Compare
artonge
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Jun 11, 2021
skjnldsv
reviewed
Jun 11, 2021
skjnldsv
requested changes
Jun 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
from
June 14, 2021 08:53
2d25756
to
dff7935
Compare
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
feature/react_to_sidebar_events
branch
from
June 14, 2021 10:13
dff7935
to
eba1a1b
Compare
Ok, should be good now @skjnldsv, I am banning |
skjnldsv
approved these changes
Jun 15, 2021
45 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the use of sidebar events dispatched on the
nextcloud-bus
to open and close the sidebar when the viewer is open.files:sidebar:opened
to open the Sidebarfiles:sidebar:closed
to close the SidebarNotable changes:
setFullScreenMode
function exposed onOCA.Files.Sidebar
. This was necessary because the Sidebar was overriding the programmatically set HTML class..app-sidebar--full
class toSidebar.vue
Need: