Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React to sidebar events from nextcloud-bus #913

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

artonge
Copy link
Contributor

@artonge artonge commented May 26, 2021

This PR adds the use of sidebar events dispatched on the nextcloud-bus to open and close the sidebar when the viewer is open.

  • Listen to files:sidebar:opened to open the Sidebar
  • Listen to files:sidebar:closed to close the Sidebar

Notable changes:

Need:

@artonge artonge force-pushed the feature/react_to_sidebar_events branch 2 times, most recently from d1e526c to b061a2e Compare May 26, 2021 16:34
@artonge artonge added 2. developing Work in progress enhancement New feature or request labels May 26, 2021
@artonge artonge force-pushed the feature/react_to_sidebar_events branch from b061a2e to 225b822 Compare May 26, 2021 16:39
@artonge artonge added this to the Nextcloud 22 milestone May 26, 2021
@artonge artonge force-pushed the feature/react_to_sidebar_events branch 2 times, most recently from d602602 to bf9bdfc Compare May 27, 2021 15:53
src/views/Viewer.vue Outdated Show resolved Hide resolved
@artonge artonge force-pushed the feature/react_to_sidebar_events branch 11 times, most recently from 9e1e4ff to 89a18a6 Compare May 31, 2021 15:51
@artonge artonge changed the title React to sidebar events React to sidebar events from nextcloud-bus May 31, 2021
@artonge artonge force-pushed the feature/react_to_sidebar_events branch from 89a18a6 to c25d68e Compare May 31, 2021 16:53
@blizzz blizzz mentioned this pull request Jun 2, 2021
57 tasks
@artonge artonge force-pushed the feature/react_to_sidebar_events branch 2 times, most recently from d7ff8a2 to 74dfc5f Compare June 8, 2021 09:40
@MorrisJobke MorrisJobke mentioned this pull request Jun 10, 2021
59 tasks
@artonge artonge force-pushed the feature/react_to_sidebar_events branch from 74dfc5f to d3a61e1 Compare June 10, 2021 08:55
@artonge artonge marked this pull request as ready for review June 10, 2021 09:02
@artonge artonge requested a review from skjnldsv June 10, 2021 09:07
@artonge artonge force-pushed the feature/react_to_sidebar_events branch 3 times, most recently from cab063f to 2d25756 Compare June 10, 2021 13:36
@artonge artonge added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 11, 2021
package.json Outdated Show resolved Hide resolved
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@artonge artonge force-pushed the feature/react_to_sidebar_events branch from 2d25756 to dff7935 Compare June 14, 2021 08:53
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the feature/react_to_sidebar_events branch from dff7935 to eba1a1b Compare June 14, 2021 10:13
@artonge
Copy link
Contributor Author

artonge commented Jun 14, 2021

Ok, should be good now @skjnldsv, I am banning npm i from my muscle memory.

@artonge artonge requested a review from skjnldsv June 15, 2021 12:01
@artonge artonge merged commit 17de9df into master Jun 15, 2021
@artonge artonge deleted the feature/react_to_sidebar_events branch June 15, 2021 15:23
@blizzz blizzz mentioned this pull request Jun 16, 2021
45 tasks
@mejo- mejo- mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants