fix: support table editing in public shares and resolve stale closures #941
+73
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silverkszlo
requested review from
grnd-alt,
hweihwang and
juliusknorr
as code owners
- Fix stale closure bug in editTable by using getState() to get fresh API/state - Support public share users in table locking by extracting user info from JWT - Make tryAcquireLock async to support JWT-based user identification - Ensure table locks use same user IDs as collaboration system Signed-off-by: silver <s.szmajduch@posteo.de>
silverkszlo
force-pushed
the
fix-tableinsertion-in-public-shares
branch
from
3ed7cdc to
05e766d
Compare
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
4 tasks
benjaminfrueh
approved these changes
Jan 15, 2026
Contributor
|
Reviewed and tested in nextcloud 29. |
juliusknorr
approved these changes
Jan 15, 2026
Member
juliusknorr
left a comment
juliusknorr
left a comment
There was a problem hiding this comment.
Also confirmed to be working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs this PR in text: nextcloud/text#8156