build(player): migrate to audioop-lts on Python >= 3.13 #1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ooliver1
added
p: high
ooliver1
approved these changes
Nov 21, 2024
Skelmis
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Reopening this because I borked my master on my fork. Sorry.
Audioop is a "dead battery" that has been removed by PEP 594 in versions of Python >= 3.13.0. Thankfully, an LTS port has been created here. This PR would switch nextcord to audioop-lts for versions of Python that no longer include audioop OOTB.
Fixes #1174.
In terms of testing, I confirmed that, on Python 3.13., audioop-lts is installed; and on Python 3.12, nothing additional is installed.