-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/Support for miri? #181
Comments
Thanks for the report! I think support for nextest should be added to cargo miri itself, and then we should figure out what nextest needs to provide to work with miri. |
Another miri usecase (described to me by @BoxyUwU) where nextest could come in handy, is having many tests where some of them are leaking memory, which makes it hard to know what test it was (at least in the absence of tagging the allocation with the thread it originated on and mapping that back). Looking at how
From a quick check, For example, I came up with this quick hack to help @BoxyUwU out: cargo --quiet test --lib -- --list | sed 's/: test$//' | xargs -n1 cargo miri test --lib -- --exact But that's much more fragile than what nextest does and AFAIK nextest invokes the test runner executable itself, so nextest going through Instead, since nextest respects In fewer words, I agree with this:
and also think it would take very little effort (assuming no weird Cargo features get in the way) (@oli-obk, @RalfJung, or someone else who works on miri may also want to chime in) |
Your summary of |
[cargo-miri] support nextest Add the ability to run `cargo miri nextest list` and `cargo miri nextest run`. [cargo-nextest](https://nexte.st) is a new test runner for Rust maintained mostly by myself. It has several new features, but the most relevant to miri is the fact that it runs [each test in its own process](https://nexte.st/book/how-it-works.html#the-nextest-model). This gives miri users better leak detection (#1481) for free, for example. See nextest-rs/nextest#181 for discussion, including comments by `@eddyb` and `@RalfJung.` Future work might be to have miri read [the list of tests](https://docs.rs/nextest-metadata/latest/nextest_metadata/struct.TestListSummary.html) (or [test binaries](https://docs.rs/nextest-metadata/latest/nextest_metadata/struct.BinaryListSummary.html)) generated by `nextest list`. `@eddyb` thinks that might be useful. I tested `cargo miri nextest run` against smallvec, and it worked great. Note: Running tests out of archives is currently broken, as the comment in run-test.py explains.
Just released cargo-nextest 0.9.27 with support for Miri. https://nexte.st/book/miri.html |
Awesome. :) |
Hi
First, thank you for this awesome project!
Using
nextest
in medium size projects such ascompact_str
andbytes
result in significant speedup.It will be great if we can also run miri using
nextest
, as miri is very slow at running tests and is single-threaded.The text was updated successfully, but these errors were encountered: