-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libtest json output option #1086
Conversation
There are a couple of todos, but the biggest missing piece is combined stdout/err output
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1086 +/- ##
==========================================
- Coverage 79.13% 78.00% -1.13%
==========================================
Files 64 69 +5
Lines 16555 17329 +774
==========================================
+ Hits 13100 13518 +418
- Misses 3455 3811 +356 ☔ View full report in Codecov by Sentry. |
d7deace
to
b697409
Compare
Thanks, will have a look at it over the weekend. For stdout/stderr, can we just do something like:
It's not great but it is emulation, after all. Seems like trying to maintain a combined buffer (or separate buffers with indexes) is possible but also adds some nontrivial complexity. |
Just FYI I've had too may commitments to review this, but hope to get to it this weekend. |
No worries, I'm doing a bunch of other stuff atm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your patience. This looks pretty good overall. Let's get this in before working on the combined output.
Running was the _total_ number of running tests, not just the ones in the same binary, which would result in only one binary output being written
Thanks for this. I really apologize for how long this has taken, I've been dealing with serious personal life issues. I think this is good to go. The only question I have is whether it's ok for this to be experimental for at least a short while. You'd have to add |
I could do that, but I don't understand the need for that additional hurdle when it already requires passing a new flag? |
It's true that it requires passing a new flag, but as machine-readable output this would need to be a stable format (which experimental features are not). I think there's just a few more things we need to do before I'd feel comfortable stabilizing this:
Once this is stabilized the format will have to be maintained forever (per our stability policy), so it's worth spending some time making sure it's all good. I'll land this and make it experimental, before getting a release out tomorrow or so. Thanks for all your work! |
There are a couple of todos, but the biggest missing piece is combined stdout/err output.
Opening this as a draft while I make the combined output helper.