Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add archive warnings #1451

Merged
merged 4 commits into from
Apr 22, 2024
Merged

add archive warnings #1451

merged 4 commits into from
Apr 22, 2024

Conversation

sunshowers
Copy link
Member

No description provided.

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 94.75219% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 78.20%. Comparing base (2f0cfc4) to head (32d9c79).
Report is 2 commits behind head on main.

Files Patch % Lines
nextest-runner/src/reuse_build/archiver.rs 85.00% 9 Missing ⚠️
cargo-nextest/src/cargo_cli.rs 87.09% 4 Missing ⚠️
nextest-runner/src/helpers.rs 80.00% 2 Missing ⚠️
cargo-nextest/src/dispatch.rs 92.85% 1 Missing ⚠️
nextest-runner/src/redact.rs 99.35% 1 Missing ⚠️
nextest-runner/src/reuse_build/archive_reporter.rs 98.27% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   77.85%   78.20%   +0.35%     
==========================================
  Files          72       73       +1     
  Lines       17473    17761     +288     
==========================================
+ Hits        13603    13890     +287     
- Misses       3870     3871       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers sunshowers force-pushed the archive-warnings branch 5 times, most recently from 9fad795 to 720b432 Compare April 22, 2024 19:16
…rgo metadata query

Previously we weren't passing in these arguments. Ensure that they're always
passed in.
We're going to redact these paths in the next commit, so it's nice to have them
all be in the reporter.
@sunshowers sunshowers force-pushed the archive-warnings branch 4 times, most recently from 286b4f7 to 4df8abb Compare April 22, 2024 21:32
To make snapshot tests work, we need to perform redactions of the sort listed.
The renovate/pin-dependencies task was failing on this.
@sunshowers sunshowers merged commit 15a8114 into main Apr 22, 2024
13 checks passed
@sunshowers sunshowers deleted the archive-warnings branch April 22, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant