[nextest-runner] put each test into a process group on unix #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for a process and all its child processes to be signaled atomically. A child process spawned by a test can choose to run in another process group, but that's quite uncommon. The one regression here is that if you press Ctrl-C, tests no longer exit. In upcoming commits we're going to fix those regressions by forwarding Ctrl-C to child processes.
On the first ctrl-C/signal, send test processes SIGINT (or SIGTERM/SIGHUP). On the second signal, send SIGKILL to test processes. On the third signal, set up a panic within nextest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for a process and all its child processes to be signaled
atomically.
A child process spawned by a test can choose to run in another process
group, but that's quite uncommon.
The one regression with process groups is that if you press Ctrl-C, tests no longer
exit. In the second commit we fix those regressions by forwarding Ctrl-C (and also SIGTERM/SIGHUP) to child process groups.
This should address rust-lang/miri#2421 on Unix. Going to do a similar patch on Windows as well.