Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove capsule dependencies #3395

Merged
merged 19 commits into from
Jul 30, 2024
Merged

remove capsule dependencies #3395

merged 19 commits into from
Jul 30, 2024

Conversation

jorgeaguileraseqera
Copy link
Contributor

This PR removes the capsule build system and uses the shadowJar plugin

Sadly, due the current launcher executes capsule the first time, in order to download and generate the classpath, we need to upgrade also the launcher

Signed-off-by: Jorge Aguilera <jorge.aguilera@seqera.io>
Signed-off-by: Jorge Aguilera <jorge.aguilera@seqera.io>
Signed-off-by: Jorge Aguilera <jorge.aguilera@seqera.io>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Copy link

netlify bot commented Dec 31, 2023

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 909a9f3
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66a8ca1a8661150008a7fe9d

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso requested a review from a team as a code owner July 29, 2024 11:12
@pditommaso
Copy link
Member

Resurrecting this PR with some improvements. Main changes:

  • Remove the dependency on deprecated Capsule loader
  • Do not rely on Maven for Nextflow installation process
  • The nextflow-*-one.jar file includes all Nextflow core modules (not plugins) and dependencies
  • Use the Gradle ShadowJar plugin to create the "one" jar file
  • The nextflow-*-all is replaced by the nextflow-*-dist package that's the same as the "one" package with self-executing ability.
  • Enable the default Nextflow plugin install/update capability for "dist" package.

@pditommaso
Copy link
Member

@bentsherman willing to give this a try?

nextflow Outdated Show resolved Hide resolved
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
nextflow Outdated Show resolved Hide resolved
nextflow Outdated Show resolved Hide resolved
pditommaso and others added 3 commits July 29, 2024 16:12
Co-authored-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso merged commit f15e424 into master Jul 30, 2024
5 checks passed
@pditommaso pditommaso deleted the remove-capsule branch July 30, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants