Fix failing CI tests #4861
Merged
Fix failing CI tests #4861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@pditommaso don't know if you did something with the github secrets but unit tests are passing here 👍 |
|
LGTM👍 |
bentsherman
changed the title
pditommaso
added a commit
that referenced
this pull request
Apr 3, 2024
This reverts commit 1c0e648.
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
This reverts commit 1c0e648. Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
This reverts commit 1c0e648. Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Apr 3, 2024
This reverts commit 1c0e648. Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
|
@pditommaso why was this PR reverted? even if it wasn't related to the google batch CI tests, they are still good changes. the docs test actually will fail sometimes without this change |
|
Becasue |
|
Then keep the docs snippet? |
|
Fair enough 6499649 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see discussion in #4712