Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GA4GH plugin #5056

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Remove GA4GH plugin #5056

merged 2 commits into from
Jun 11, 2024

Conversation

pditommaso
Copy link
Member

This PR removes the GA4GH TES plugin from the Nextflow core codebase. The plugin source code will be maintained in the nf-ga4gh repository

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@pditommaso pditommaso requested a review from a team as a code owner June 10, 2024 17:44
Copy link

netlify bot commented Jun 10, 2024

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit cd12713
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/66673dcc3cbf2500082c1881
😎 Deploy Preview https://deploy-preview-5056--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
@bentsherman
Copy link
Member

Why is the latest version 1.1.0-patch1 when the previous version was 1.3.0? Isn't that going to mess up the plugin version picker?

@pditommaso
Copy link
Member Author

It should not. 1.3.0 is greater than 1.1.0-patch1

@pditommaso pditommaso merged commit 0471b2e into master Jun 11, 2024
22 checks passed
@pditommaso pditommaso deleted the externalize-ga4gh-tes branch June 11, 2024 10:20
@bentsherman
Copy link
Member

I'm confused. You made the standalone plugin 1.1.0 , so Nextflow will always select the "old" version 1.3.0 by default?

@pditommaso
Copy link
Member Author

it should not, because it requires 23.10.2

https://github.com/nextflow-io/plugins/blob/main/plugins.json#L1214-L1218

@bentsherman
Copy link
Member

so if I release a new version of the plugin, should I start from 1.1.0 or 1.4.0 ?

@pditommaso
Copy link
Member Author

1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants