Fix the cleanup of local secret file

[pditommaso]

This PR fixes the cleanup of secret files created by the local provider

[netlify]

✅ Deploy Preview for nextflow-docs-staging canceled.

Name	Link
🔨 Latest commit	014b442
🔍 Latest deploy log	https://app.netlify.com/sites/nextflow-docs-staging/deploys/667050cd3592ec00081e5b13

[marcodelapierre]

I have added deleteOnExit() also for when the path is preexisting.
This makes the behaviour retroactive, for tmp files with matching hash.

What do you think?

[pditommaso]

Umm, not sure anymore it should be deleted 😄

[marcodelapierre]

Why are you not convinced?
I mean, fair enough from my perspective, mostly curious. The source of truth should be store.json anyway.

If not deleted, I expect the impact on users still to be quite limited: the only ones experiencing inconsistencies would be those using a literal $ symbol in the secret. And the workaround for them is simply a one-off manual deletion of those temporary files.

[pditommaso]

The point that file could be deleted during a by a run while a concurrent execution is running.

I think the temp file is removed, then the file name should be unique i.e. using a random uuid

[marcodelapierre]

See now - added a random UUID to the filename.
I did not use the session uniqueID, as it seemed an overshooting to expose the session object all the way to this class.

(oops closed by accident - reopened!)

[pditommaso]

Ouch got messed with unrelated commits

[marcodelapierre]

unrelated commits should be fine now, see changelog

[marcodelapierre]

(still showing extra commits in commit list, as I rebased to sign off one commit)