Disable AWS spot retry #5215
Merged
Disable AWS spot retry #5215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Need to also update the docs for |
|
Do you think we should do the same for |
|
Good point, yes. For some reason I was convinced that google was defaulting to zero |
|
Opened #5223 to handle Google one |
pditommaso
added a commit
that referenced
this pull request
Sep 4, 2024
This commit disables the AWS Batch spot auto-retries. The main reasons to disable this capability is: * The same tasks can be re-tried multiple times incurring in significant spending increase with the user is a aware of that * The AWS automatic retry re-execute a task in the same working directory because it's not directly managed by nextflow. This can introduce nasty side effects with partial/corrupted data left in a previous execution * There's not log/visual feedback during the pipeline execution, because it's managed directly by AWS Batch. User can still enable this capability by setting the following option: ``` aws.batch.maxSpotAttempts = n ``` where n is a integer > 0 Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Ben Sherman <bentshermann@gmail.com> Co-authored-by: Ben Sherman <bentshermann@gmail.com>
nschan
pushed a commit
to nschan/nextflow
that referenced
this pull request
Sep 12, 2024
This commit disables the AWS Batch spot auto-retries. The main reasons to disable this capability is: * The same tasks can be re-tried multiple times incurring in significant spending increase with the user is a aware of that * The AWS automatic retry re-execute a task in the same working directory because it's not directly managed by nextflow. This can introduce nasty side effects with partial/corrupted data left in a previous execution * There's not log/visual feedback during the pipeline execution, because it's managed directly by AWS Batch. User can still enable this capability by setting the following option: ``` aws.batch.maxSpotAttempts = n ``` where n is a integer > 0 Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Ben Sherman <bentshermann@gmail.com> Co-authored-by: Ben Sherman <bentshermann@gmail.com> Signed-off-by: Niklas Schandry <niklas@bio.lmu.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disables the automatic retry made by AWS Batch when a spot instance is reclaimed.
The main reasons to disable this capability is:
Keep it aligned with same feature with Google Batch that's disabled by default.User can still enable this capability by setting the following option:
where
nis a integer > 0