Disable automatic detection of virtual threads #5270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
bentsherman
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Good idea. See #4995 for a proposed solution to the problems reported around virtual threads.
I think the problem is not the virtual threads themselves but the lack of a pool size. They say "you don't need a pool anymore, just make a virtual thread!" but if every thread is doing heavy I/O (e.g. publishing) then you will still overwhelm the system.
So we need some kind of queue that allows for unlimited threads but limits the level of concurrent processing and I/O. Maybe that's just the existing platform thread pool... need to think on it more.
pditommaso
added a commit
that referenced
this pull request
Sep 4, 2024
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of Java virtual threads is supported as experimental feature. This PR disables the automatic use of virtual threads with Java 21 or later.