-
Notifications
You must be signed in to change notification settings - Fork 762
Fix hash when CmdEvalParam as output #5517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix hash when CmdEvalParam as output #5517
Conversation
✅ Deploy Preview for nextflow-docs-staging canceled.
|
40ecdc4 to
d605b2b
Compare
|
This alter the assumption the task is idempotent. The task hash should only rely on the inputs not on the outputs |
|
I see the point it could be considered as part of the execution script, but still in principle it should not be needed to re-run the task |
|
Considering that eval is a shorthand for export an output env var in the script, it is essentially part of the script and therefore part of the task identity. I think it is possible to evaluate the task outputs without "resolving" or "collecting" them, before computing the task hash. Then you can see if any output evals were declared and include them as if they were part of the script |
5a93547 to
27345a6
Compare
b4b321e to
069653d
Compare
7971fc1 to
af3d7bc
Compare
Signed-off-by: jorgee <jorge.ejarque@seqera.io> Signed-off-by: Ben Sherman <bentshermann@gmail.com>
af3d7bc to
3ec20f0
Compare
|
This needs to be marked as a cache breaking change in the changelog |
|
also I really not sure about this, because break the contract that task ID depends only on inputs + script |
|
The eval commands are part of the script |
This reverts commit b0fe0a9. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
This reverts commit b0fe0a9. Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
close #5470
Adds the CmdEvalParams in the task outputs as a key to compute the hash