Fix azure repos when clone URL is used #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jorgee
commented
Jan 14, 2025
jorgee
commented
- Add support for Clone URL.
- Unifies the parse of URL path to extract organization, project and repository in all the supported cases. (AzureRepositoryProvider.getUniformPath). It is used in the AzureRepositoryProvider constructor to get the project and repo and in the ProviderConfig.resolveProjectName used when pulling the pipeline from a repo.
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Before ❌ : After ✅ : Beautiful, thanks @jorgee! |
pditommaso
reviewed
Jan 14, 2025
modules/nextflow/src/main/groovy/nextflow/scm/AzureRepositoryProvider.groovy
Outdated
Show resolved
Hide resolved
…rovider.groovy Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Signed-off-by: Jorge Ejarque <jorgee@users.noreply.github.com>
Is it also working with Platform? |
Platform imports the code, so we can't test it until a platform engineer updates the code itself. |
|
Dmitry, just tested it in platform. @pditommaso I think it is ready to review and merge. Should we backport the changes to 24.10.4? |
…rmat-is-provided-in-azure-repos
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
pditommaso
reviewed
Jan 15, 2025
modules/nextflow/src/main/groovy/nextflow/scm/AzureRepositoryProvider.groovy
Show resolved
Hide resolved
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
pditommaso
approved these changes
Jan 15, 2025
…lone-url-format-is-provided-in-azure-repos
pditommaso
deleted the
5665-incorrect-behaviour-when-clone-url-format-is-provided-in-azure-repos
branch
pditommaso
added a commit
that referenced
this pull request
Jan 20, 2025
Signed-off-by: jorgee <jorge.ejarque@seqera.io> Signed-off-by: Jorge Ejarque <jorgee@users.noreply.github.com> Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com> Co-authored-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.