Change task array submission commad in Google Batch #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
…atch Signed-off-by: jorgee <jorge.ejarque@seqera.io>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Signed-off-by: jorgee <jorge.ejarque@seqera.io>
…oogle-batch-and-task-array
Signed-off-by: Paolo Di Tommaso <paolo.ditommaso@gmail.com>
|
Bit unfortunate, because in principle the double-command (plain vs array) should be implemented also for the other executors. Anyhow, let's go ahead, and we'll look a more structural solution later on. Made a minor change to not modify the GoogleBatchScriptLauncher signature because I think it's extended in the xpack plugin |
pditommaso
deleted the
5777-not-detected-failing-condition-with-google-batch-and-task-array
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5777
This PR modifies the execution command for task arrays to directly run the task command avoiding race conditions when using gcfuse.