highlight co2e values in the report #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Did a bit more work on the raw HTML, sorry @mirpedrol 😬 |
ewels
approved these changes
Oct 9, 2023
There was a problem hiding this comment.
Haven't tested the plugin myself, but a quick skim of the template looks good 👍🏻
I might do a bit more on this yet, but happy to do that as a PR myself "one day when I have time", rather than sending raw HTML files 😁
Thanks @mirpedrol !
|
It looks nice! But there is a line break when the text becomes longer, and the value for the plane (0.0?) is missing for the test run |
ewels
reviewed
Oct 11, 2023
plugins/nf-co2footprint/src/resources/CO2FootprintReportTemplate.html
Outdated
Show resolved
Hide resolved
plugins/nf-co2footprint/src/resources/CO2FootprintReportTemplate.html
Outdated
Show resolved
Hide resolved
|
|
Co-authored-by: Phil Ewels <phil.ewels@seqera.io>
|
It looks good for me with these last changes, could you try again @skrakau to make sure it does work for your test too? |
skrakau
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.