Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed output files #83

Merged
merged 3 commits into from
Jan 11, 2024
Merged

Conversation

skrakau
Copy link
Collaborator

@skrakau skrakau commented Jan 11, 2024

Hi, I thought some more consistent output filenames would be nice.

What would you think about

  • co2footprint-<timestamp>.txt -> co2footprint_trace_<timestamp>.txt
  • co2footprint-<timestamp>.summary.txt -> co2footprint_summary_<timestamp>.txt
  • co2footprint-report-<timestamp>.html -> co2footprint_report_<timestamp>.html
    ?

Would it make sense to make use of the Nextflow trace wording? Then it would be somehow analogous to the nf-core execution_report_* and execution_trace_* naming.

If yes, then I would also rename the variable names to avoid confusion

@skrakau skrakau requested a review from mirpedrol January 11, 2024 08:14
@skrakau skrakau force-pushed the adjust_output_names branch 2 times, most recently from d0ede51 to 9537f82 Compare January 11, 2024 08:59
@skrakau skrakau force-pushed the adjust_output_names branch from 9537f82 to b8653a9 Compare January 11, 2024 09:03
@skrakau skrakau marked this pull request as ready for review January 11, 2024 09:04
@skrakau
Copy link
Collaborator Author

skrakau commented Jan 11, 2024

OK, ready for review. I also added using a timestamp to the example custom config file.

Copy link
Collaborator

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@skrakau skrakau merged commit 486db86 into nextflow-io:dev Jan 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants