-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update java and grade version #94
update java and grade version #94
Conversation
Hi @Bastian-Eisenmann, usually java tests should also run on smaller java versions, maybe you can have a look if gradle 8.11 has any requirements which are not met? If not, you can als try to increment the CI tests to other versions, or at least the higher version to java 23 👍 |
Hi, |
If the version work together, I'm fine with upgrading! I aligned the versions to nextflow, but also they incremented to gradle 8.10 since then! Do you know if grade is backwards compatible with older java versions? |
java version 23 must be included
This reverts commit 67b1315.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great it's working now! Can you sign your commits? There are some code snippets you can use in the details of the CI test 👍
Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
java version 23 must be included Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
This reverts commit 67b1315. Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
… for java 23 Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
…com/Bastian-Eisenmann/nf-co2footprint into feature/update-java-grandle-version
That did not work, have you followed the instructions in the details of the CI test? Would you mind opening a new branch and PR so we do not blow up the commits for a version bump? 😆 |
I did but seems like the final commit was again without that signing message... yeah, I will just create a new one, that should finally work :-) |
No description provided.