Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update java and grade version #94

Conversation

Bastian-Eisenmann
Copy link
Collaborator

No description provided.

@tillenglert
Copy link
Collaborator

Hi @Bastian-Eisenmann, usually java tests should also run on smaller java versions, maybe you can have a look if gradle 8.11 has any requirements which are not met? If not, you can als try to increment the CI tests to other versions, or at least the higher version to java 23 👍

@Bastian-Eisenmann
Copy link
Collaborator Author

Hi,
in my previous project we tried to keep the java & tools versions as high as possible (often also with some kind of ci/cd automatic update) and also parallel at all parts of the project.
On my pc was java version 23 installed which hasn´t worked with the given config because gradle 8.9 is not compatible to java 23 (https://docs.gradle.org/current/userguide/compatibility.html) - however, with installing a lower java version the current configuration does probably work.
I can also undo the commit 3c447e2 but would keep the gradle version update so that there will be no problems when java version 23 is used.

@tillenglert
Copy link
Collaborator

If the version work together, I'm fine with upgrading! I aligned the versions to nextflow, but also they incremented to gradle 8.10 since then! Do you know if grade is backwards compatible with older java versions?

Copy link
Collaborator

@tillenglert tillenglert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great it's working now! Can you sign your commits? There are some code snippets you can use in the details of the CI test 👍

Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
java version 23 must be included

Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
This reverts commit 67b1315.

Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
… for java 23

Signed-off-by: Bastian Eisenmann <bastian.eisenmann@uni-tuebingen.de>
@tillenglert
Copy link
Collaborator

That did not work, have you followed the instructions in the details of the CI test? Would you mind opening a new branch and PR so we do not blow up the commits for a version bump? 😆

@Bastian-Eisenmann
Copy link
Collaborator Author

That did not work, have you followed the instructions in the details of the CI test? Would you mind opening a new branch and PR so we do not blow up the commits for a version bump? 😆

I did but seems like the final commit was again without that signing message... yeah, I will just create a new one, that should finally work :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants