Move secret config one level up

[jagedn]

Currently secret config is under job section

What do you think if we promote one level up in order to simplify the configuration ?

so instead

nomad {
    jobs {
        namespace = 'nf-nomad'
        secrets {
            enabled = true //if false then use LocalSecretsProvider implementation
        }
    }
}

use

nomad {

    client {
        address = "http://localhost:4646"
    }

    jobs {
        deleteOnCompletion = false
        volume = { type "host" name "scratchdir" }
        namespace = 'nf-nomad'
  }
   secrets {
          enabled = true //if false then use LocalSecretsProvider implementation
   }

}

@abhi18av ?

[abhi18av]

Hi @jagedn ,

I think it makes sense from the design perspective 👍

Keeping in mind that the overall intent is that the specific secrets can also be provided via the withName or withLabel selectors in Nextflow config.

Therefore, this secrets.enabled would be the only field within the nomad.secrets store no?

[jagedn]

no the only, also path is used

[abhi18av]

Ah, okay - found it

nf-nomad/plugins/nf-nomad/src/main/nextflow/nomad/config/NomadSecretOpts.groovy

Line 10 in 66dc755

this.path = map.path ?: "secrets/nf-nomad"

Then, let's take this forward